min_relay_fee check during channel funding #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11630993136Details
💛 - Coveralls |
|
Something I forgot to add in my "update to 0.18.4" PR which we should add here (since we're using another RPC field of |
gijswijs
force-pushed
the
minrelayfee
branch
2 times, most recently
from
768ed0c to
2e01831
Compare
guggero
reviewed
Nov 1, 2024
To support the new `min_relay_fee_sat_per_kw` in the `lnd` RPC call `EstimateFee`, we need to bump the `minimalCompatibleVersion` to `0.18.4`.
With the `minimalCompatibleVersion` bumped to `0.18.4` we can assume support for the `GetBlockHeader` RPC call. This removes the check for support of the `GetBlockHeader` RPC call.
This commit removes the version check for lnd in the `FundVirtualPsbt` since we can assume the new coin selection mode in the FundPsbt call with the minimal lnd version now being `0.18.4`.
This commit adds `MinRelayFee` to the `WalletAnchor` and uses it during tapchannel funding to check whether the feerate meets the minimum relay fee.
jharveyb
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Nice to remove all these checks - LGTM!
I think we should have a follow-up PR to add similar logic to the minter, I know there have been issues there also.
I think this is the right spot, or at least related:
taproot-assets/tapgarden/planter.go
Line 552 in 420f246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
MinRelayFeeto theWalletAnchorand uses it during tapchannel funding to check whether the feerate meets the minimum relay fee.fixes: #1105
This PR depends on lightninglabs/lndclient#200 and uses a pseudoversion of that package.go.mod should be changed before merging this PR,